Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor vstgui lv2 #397

Merged
merged 24 commits into from
Sep 4, 2020
Merged

Editor vstgui lv2 #397

merged 24 commits into from
Sep 4, 2020

Conversation

jpcima
Copy link
Collaborator

@jpcima jpcima commented Aug 31, 2020

This implements the current UI made in VSTGUI into LV2.
It's decoupled from VST from now, and it can serve as transitional PR into the more elaborate UI.

Needs test for regressions.

There is a segfault in jalv.gtk 1.6.4 when exiting, but it may be the fault of jalv only.

@jpcima
Copy link
Collaborator Author

jpcima commented Aug 31, 2020

Note: LV2 bundle had to be reorganized with a Contents/ directory structure, so vstgui can access resources files without modifying the code.
This is going to disturb states which refer to the default instrument/scala files inside.

@jpcima jpcima force-pushed the editor-vstgui-lv2 branch from 3a1289b to d91bec7 Compare August 31, 2020 08:46
@jpcima
Copy link
Collaborator Author

jpcima commented Aug 31, 2020

absl::variant is broken when the Travis builds set standard to C++17..
It has a link error with ThrowBadVariantAccess.
so I'll substitute it with something else.

@jpcima jpcima marked this pull request as ready for review August 31, 2020 19:15
@jpcima jpcima requested a review from paulfd August 31, 2020 19:15
@jpcima
Copy link
Collaborator Author

jpcima commented Sep 4, 2020

Segfault problems are resolved in the latest commit.
It seems OK for merge.

@jpcima jpcima merged commit acce5d4 into sfztools:develop Sep 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants