Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User interface update #404

Merged
merged 18 commits into from
Sep 11, 2020
Merged

User interface update #404

merged 18 commits into from
Sep 11, 2020

Conversation

jpcima
Copy link
Collaborator

@jpcima jpcima commented Sep 7, 2020

New user interface. This has all functionality of the old one.

The new functionality will need support on sfizz side in a future work.

  • memory usage
  • controller values (read/write)
  • key switches
  • key ranges
  • sending notes

@jpcima jpcima requested a review from paulfd September 7, 2020 12:52
@paulfd
Copy link
Member

paulfd commented Sep 10, 2020

Do you have a screen of how the interface is supposed to look?

@alcomposer
Copy link
Collaborator

alcomposer commented Sep 10, 2020

Further to the features needed in sfizz backend:

  • output level meter

@jpcima
Copy link
Collaborator Author

jpcima commented Sep 10, 2020

Current UI looks like this on the main panel.

Capture du 2020-09-10 20-40-50

The instrument information can be on the main tab
Put the button behind the logo
Embed the ABeeZee font and use it everywhere
Add hover colors to glyph buttons
Replace the "file open" glyph by a folder
@paulfd
Copy link
Member

paulfd commented Sep 11, 2020

With my system it did not look like this at all. I embedded the "logo" font and used it, but we can change 🙂
Screenshot from 2020-09-11 03-25-05

In the logo it's fine but in the interface it looks slightly childish I think.

editor/src/editor/Editor.cpp Show resolved Hide resolved
@alcomposer
Copy link
Collaborator

alcomposer commented Sep 11, 2020

Roboto font family is a very high quality open font. Example of it used in sfizz. I think this looks much better, especially for numbers.
ABeeZee font (current) is a children's learning font? I don't think this is the best place for it.

roboto

NOTES

  • Remove icons for open & edit in external editor and replace with downward chevron dropdown menu that contains both (and possibly more items)
  • Have the file name area itself as an open dialogue LMB action. (This is expected behaviour- and nothing wrong in having open file in two places)
  • Add downward chevron to keyswitch select & Max polyphony value
  • I'm not sure about using home icon, is there a home in sfizz? I would suggest 4 icons:
    Screenshot from 2020-09-04 19-43-52
  • Icons arranged in most used to the centre of the interface: Settings, Info, Controls, SFIZZ-XML / artwork.
  • Highlighting the icon on hover feels wrong- it could be a button area highlight?
  • LMB over sfizz logo icon to open About Sfizz pop-up.
  • Consider changing KS to K-Switch

@jpcima
Copy link
Collaborator Author

jpcima commented Sep 11, 2020

  • +1 for roboto font
  • if you add a picture, include a 2x variant and run it through optipng

I'm not sure about using home icon, is there a home in sfizz? I would suggest 4 icons:

Imo, large text+icon is excessive at the top right.
Remove sfizz's large icon to leave just the text, then change the home icon to sfizz icon.

@paulfd
Copy link
Member

paulfd commented Sep 11, 2020

* +1 for roboto font

* if you add a picture, include a 2x variant and run it through optipng

I'm not sure about using home icon, is there a home in sfizz? I would suggest 4 icons:

Imo, large text+icon is excessive at the top right.
Remove sfizz's large icon to leave just the text, then change the home icon to sfizz icon.

It's a bit sad to put unfa's work small no? Maybe an engraving in the background...

@jpcima
Copy link
Collaborator Author

jpcima commented Sep 11, 2020

Maybe an engraving in the background...

I'll be ok with such a choice.
Personnally, I am disturbed by the sfizz text not being center-aligned in the box.
Or perhaps, expand the hbox a bit more and space the buttons, as in Alex's mockup above.

@alcomposer
Copy link
Collaborator

alcomposer commented Sep 11, 2020

WIP Mock-up of left two panels:
Screenshot from 2020-09-11 19-58-33

Notes:

  • Roboto font
  • sfizz brand text center
  • Grey highlight under tab icon when mouse hover
  • Active dot under tab icon for active tab
  • Left-Right chevron for moving to next-previous SFZ script in folder
  • Downward chevron for file options dropdown: load, edit in external editor, duplicate & edit etc
  • Green SFZ engine status indicator. GREEN= all good. RED Cross Icon= error. LOADING throbber= loading.
  • LMB on status indicator to bring up per instance sfizz engine log.

@jpcima
Copy link
Collaborator Author

jpcima commented Sep 11, 2020

I updated the file dialog of vstgui according to Robin's advice, this is expected to work in the Ardour6 binary bundle.

@jpcima jpcima merged commit e8cc1fa into sfztools:develop Sep 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants