Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Midnam fixes #420

Merged
merged 4 commits into from
Sep 16, 2020
Merged

Midnam fixes #420

merged 4 commits into from
Sep 16, 2020

Conversation

jpcima
Copy link
Collaborator

@jpcima jpcima commented Sep 16, 2020

Fixes following issues

  • exporting CC outside of MIDI range
<Control Type="7bit" Number="300" Name="Foo" />
  • exporting labels twice if they appear in SFZ several times
    example: <control>label_cc20=Foo label_cc20=Bar
<Control Type="7bit" Number="20" Name="Foo" />
<Control Type="7bit" Number="20" Name="Bar" />

@jpcima jpcima requested a review from paulfd September 16, 2020 09:38
@jpcima jpcima merged commit 3a1964e into sfztools:develop Sep 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulfd paulfd paulfd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jpcima @paulfd