Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Store the initial values of controllers #421

Merged
merged 2 commits into from
Sep 20, 2020
Merged

Store the initial values of controllers #421

merged 2 commits into from
Sep 20, 2020

Conversation

jpcima
Copy link
Collaborator

@jpcima jpcima commented Sep 16, 2020

Keep the initial values of controllers for the active instrument.
Having this data will permit to make the UI aware about default values for the CC sliders.

@jpcima jpcima requested a review from paulfd September 16, 2020 12:53
@paulfd
Copy link
Member

paulfd commented Sep 17, 2020 •
edited
Loading

So purely philosophical, but I guess the init functions could be private? The getter on the other hand could even have a public API I guess.

@jpcima jpcima merged commit 2f930d5 into sfztools:develop Sep 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulfd paulfd paulfd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jpcima @paulfd