Test region values through the OSC interface #555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulfd
force-pushed
the
osc-region-introspection
branch
2 times, most recently
from
06b938e to
d4f3691
Compare
jpcima
force-pushed
the
osc-region-introspection
branch
from
d4f3691 to
171a5e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some tests are commented pending the update to the region opcode parsing that I have queued. Also I guess this should use #545 down the line, rather than the ad-hoc helpers I made.
We can assume that the OSC interface is not stable for now, but we'll need an efficient way to document it I think. Something we should discuss: I used 0-based indexing (except for effects, where effect0 is the main bus), but maybe it's confusing considering sfz is 1-based.