Updating regions through OSC #761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For a limited selection of opcodes, we can allow updates through OSC. This implements an "opcode buffer" that gets read at the beginning of the render loop in the RT thread. Any opcode updates must thus be RT-safe, so not all of them should be allowed. I added a parameter to disable the opcode name cleanup method which does allocate strings potentially. This means that the opcodes must be "correctly" normalized. For example, for `lfoN_wave`, we have to pass `lfoN_wave1` in the opcode buffer.
paulfd
force-pushed
the
osc-region-change
branch
from
2a323d8 to
78db0b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For a limited selection of opcodes, we can allow updates through OSC.
This implements an "opcode buffer" that gets read at the beginning of the render loop in the RT thread.
Any opcode updates must thus be RT-safe, so not all of them should be allowed.
I added a parameter to disable the opcode name cleanup method which does allocate strings potentially.
This means that the opcodes must be "correctly" normalized.
For example, for
lfoN_wave, we have to passlfoN_wave1in the opcode buffer.This can be seen as very experimental, mostly to be used by @rghvdberg for now.