-
-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Present the controllers as LV2 parameters #776
Conversation
Approach 1 is also how this would work in VST3 (with |
I think option 3) would limit available functionality severely. Host support for MIDI mapping is lacking, esp. when it comes to remapping values ranges, curves or mapping the same CC to multiple targets |
Except in VST3 the host does the disambiguation, here the plugin would. I would still go with option 1 though. |
Following @falkTX 's suggestion on IRC, we might use the property It's not an implemented feature in any current hosts; falkTX considers it for Carla 2.3 if we implement it.
|
@paulfd Normally those per-channel 'pseudoparameters' used for |
@robbert-vdh We're not setting hidden flags on parameters, as these imply read-only. |
@jpcima That |
case LV2_MIDI_MSG_CONTROLLER: | ||
// Note(jpc) CC must be mapped by host, not handled here. | ||
// See LV2 midi:binding. | ||
/*case LV2_MIDI_MSG_CONTROLLER: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So if the host does not support midi:binding
this behaves like option 3?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is the case indeed. This would be nicer if the midi:binding
feature could be checked.
Also and unrelated, this work lacks support of properly saving and restoring CC parameter values, I have to check this next.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this feature documented anywhere? If not and we're basically doing it live, I think having ways to check for host support is a bit required.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If not and we're basically doing it live
It's true; on the other hand, this benefits LV2 and the community at large, and LV2 sometimes really needs some features like this.
VST3 is, and will remain probably a while, our recommended format of plugin.
@falkTX, may there be a feature check for support of |
I do not think midi:binding is valid as an lv2 feature. we should ask on the lv2 mailing list. |
I'm merging this LV2 work, which has now complete save/restore functionality for CC. |
A work in progress to have CC as parameters.
It would permit to manipulate the SFZ controllers from 128 and up.
For the parameters 0-127, there are multiple options
There can be some inconveniences
Thoughts?
(Note: sforzando, in VST2, goes with the option 1.)