lv2: A6 workaround, single output atom port #924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, some `patch:Set` messages were directed to a distinct atom port, when it was for notification purposes rather than automation. Ardour does not support this, and the ports get assigned the same buffer, producing corruption. This commit returns to single-port behavior, and instead replaces `patch:Set` notification messages with `sfizz:Notify` custom objects; the UI processes these messages all the same, and they does not trigger automation in the host.
|
Should we change the LV2 version number given that the ports have changed? |
Yes, do you prefer now or before a release? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, some
patch:Setmessages were directed to a distinct atomport, when it was for notification purposes rather than automation.
Ardour does not support this, and the ports get assigned the same
buffer, producing corruption.
This commit returns to single-port behavior, and instead replaces
patch:Setnotification messages withsfizz:Notifycustom objects;the UI processes these messages all the same, and they does not trigger
automation in the host.