Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a check for sustain and sostenuto in the LV2 #963

Merged
merged 1 commit into from
Sep 10, 2021

Conversation

paulfd
Copy link
Member

@paulfd paulfd commented Jul 24, 2021

If the midi message is a sustain or sostenuto, pass it on regardless of the plugin-side automation compile time switch.
Also hide sustain/sostenuto CCs from the UI controls; most of the time they're for pedal noises and things like this.

  • Test all configurations

Closes: sfztools/sfizz-ui#49

@paulfd paulfd requested a review from jpcima July 24, 2021 17:10
If the midi message is a sustain or sostenuto, pass it on regardless of the plugin-side automation compile time switch.
Also hide sustain/sostenuto CCs from the UI controls; most of the time they're for pedal noises and things like this.
@paulfd paulfd force-pushed the sustain-sostenuto-psa branch from dd2e4f2 to 57a41fd Compare July 24, 2021 17:11
@paulfd paulfd merged commit fbac436 into sfztools:develop Sep 10, 2021
@paulfd paulfd deleted the sustain-sostenuto-psa branch January 21, 2022 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sustain pedal issues in the LV2 plugin, and more general MIDI bindings questions
1 participant