Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build with Apple clang & C++17 (bessel functions not defined) #978

Merged
merged 1 commit into from
Aug 22, 2021

Conversation

mikeperri
Copy link
Contributor

The cyl_bessel_i function isn't defined if you're building with clang, but MathHelpers assumes it is as long as you're using C++17. So we need to add a check for that feature.

I tested this on an Intel Mac. CMake identifies the compiler as "AppleClang 12.0.5.12050022."

I added

SET(CMAKE_CXX_STANDARD 17)
SET(CMAKE_CXX_STANDARD_REQUIRED ON)

to the root CMakeLists.txt, and I ran

cmake -DCMAKE_BUILD_TYPE=Release .
make -j$(sysctl -n hw.ncpu)

@mikeperri mikeperri changed the title Fix build with clang & C++17 (bessel functions not defined) Fix build with Apple clang & C++17 (bessel functions not defined) Aug 22, 2021
@jpcima jpcima merged commit fc1f045 into sfztools:develop Aug 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants