Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Note supers are hard to spot #14

Open
Gidgidonihah opened this issue Jun 3, 2016 · 4 comments
Open

Note supers are hard to spot #14

Gidgidonihah opened this issue Jun 3, 2016 · 4 comments

Comments

@Gidgidonihah
Copy link

The supers for notes are the same color as the percentage to which they belong making them hard to see. It would be nice if they were all a consistent color (not the red/yellow/green) so I could see the note, and spot which version it applies to easily.

caniuse let example

@sgentle
Copy link
Owner

sgentle commented Jun 4, 2016

Good idea! Would you be willing to submit a pull request?

You'll probably want to change this line where the supers are displayed next to the version and this one where they're displayed next to the actual note.

I figure both places should be the same, either white/unstyled or a new and different colour from the existing red/yellow/green, right? I'm happy with whatever looks best.

@Gidgidonihah
Copy link
Author

If I'm reading it right, I would also have to change how the colors are applied? I was going to submit a pull request but coffee script is foreign to me. Maybe I can spend some time figuring it out and get a PR in eventually when I do.

@sgentle
Copy link
Owner

sgentle commented Jun 6, 2016

I'm not sure if you'd have to change how the colours are applied... are you talking about whether you'd need to do the colouring at a different level so that the super colour and the warning/spec colour don't interfere? I'm pretty sure the color module handles nesting okay. But maybe I'm misunderstanding your question...

You might find coffeescript isn't as daunting as it seems, these days it's basically ES6 with significant whitespace. :D If anything's giving you trouble feel free to pipe up here, I'm happy to help.

@AdrianoCahete
Copy link
Contributor

AdrianoCahete commented Jun 18, 2016

Space to note itself is ok, to version i think create too space.

caniuse_spacespng

mkalmykov added a commit to mkalmykov/caniuse-cmd that referenced this issue Sep 4, 2017
mkalmykov added a commit to mkalmykov/caniuse-cmd that referenced this issue Sep 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants