Common dimensions in schema #361
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bio2zarr/vcz.py
Outdated
|
|
||
| if dimensions is None: | ||
| self.dimensions = { | ||
| "variants": {"size": 0, "chunk_size": 1000}, |
There was a problem hiding this comment.
Let's define a simple dataclass for Dimension rather than programming with nested dicts
benjeffery
force-pushed
the
dimensions-schema
branch
from
ff81b5c to
b4514d6
Compare
benjeffery
changed the title
|
Should be ready for review now. |
benjeffery
force-pushed
the
dimensions-schema
branch
from
b4514d6 to
8915f73
Compare
| self.samples_chunk_size = samples_chunk_size | ||
| if dimensions is None: | ||
| dimensions = { | ||
| "variants": VcfZarrDimension(size=0, chunk_size=1000), |
There was a problem hiding this comment.
We're distributing this default to three different locations around the code, I think we need to consolidate this somehow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #351
Thought I would get a quick review here before I fix up the tests. I've had to add side effects to
convert_local_allele_field_typesso that it adds the dimensions it is using to the schema, feels a bit messy.