Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix type error in diversity and Tajimas_D. #639

Merged
merged 1 commit into from
Jul 26, 2021
Merged

Fix type error in diversity and Tajimas_D. #639

merged 1 commit into from
Jul 26, 2021

Conversation

timothymillar
Copy link
Collaborator

Fixes #638

@codecov-commenter
Copy link

codecov-commenter commented Jul 24, 2021 •
edited
Loading

Codecov Report

Merging #639 (870141d) into main (54e967d) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #639   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           35        35           
  Lines         2806      2806           
=========================================
  Hits          2806      2806
Impacted Files Coverage Δ
sgkit/stats/popgen.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54e967d...870141d. Read the comment docs.

@jeromekelleher jeromekelleher requested a review from tomwhite July 24, 2021 08:46
tomwhite
tomwhite approved these changes Jul 26, 2021
View reviewed changes
Copy link
Collaborator

@tomwhite tomwhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @timothymillar

@tomwhite tomwhite added the auto-merge Auto merge label for mergify test flight label Jul 26, 2021
@mergify mergify bot merged commit dcb3f61 into sgkit-dev:main Jul 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomwhite tomwhite tomwhite approved these changes

Assignees
No one assigned
Labels
auto-merge Auto merge label for mergify test flight
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Type error in diversity and Tajimas_D with xarray 0.19.0
3 participants
@timothymillar @codecov-commenter @tomwhite