[API] Adding support for serving of DiffUsers models.#489
[API] Adding support for serving of DiffUsers models.#489slin1237 merged 1 commit intosgl-project:mainfrom
Conversation
Summary of ChangesHello @shenoyvvarun, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly expands the platform's capabilities by integrating native support for DiffUsers models. It introduces new API fields to precisely define diffusion pipeline components within model and runtime specifications, and enhances the runtime selection mechanism to intelligently match models with compatible serving environments. This foundational work enables seamless deployment and management of advanced generative AI models, exemplified by the inclusion of a Qwen-Image model configuration. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces support for serving DiffUsers models, a significant enhancement. The changes span across API definitions, CRDs, runtime selection logic, and include new sample configurations. The overall implementation is solid, but I've identified a potential logic issue in the new runtime matching code that could lead to incorrect compatibility checks. I've also pointed out a couple of minor inconsistencies for improvement. My feedback aims to improve the correctness and maintainability of the new functionality.
6c85ee9 to
2bcde70
Compare
What this PR does
Key Design choice
Other fields depends on the model but, these are the most common. (I can remove this based on feedback)
Why we need it
Fixes #
How to test
Checklist
make testpasses locallyFollowups