[Bugfix] Fix multinode Service selector to correctly match head pods#494
[Bugfix] Fix multinode Service selector to correctly match head pods#494bcfre wants to merge 1 commit intosgl-project:mainfrom
Conversation
Signed-off-by: bcfre <guo0xiong1feng@gmail.com>
Summary of ChangesHello @bcfre, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves a critical bug where the multinode Service selector was insufficient, preventing proper identification and routing of traffic to LWS head pods. By enhancing the selector with an additional Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request addresses a bug in multinode deployments where the Service selector was not specific enough, potentially causing it to select head pods from other deployments. The fix correctly adds the app label to the selector in NewMultiNodeReconciler, ensuring that the Service only targets the intended head pods for the specific InferenceService component. The change is straightforward, correct, and effectively resolves the issue.
What this PR does
This PR fixes an issue where the multinode Service selector was incomplete, causing the Service to fail to correctly select and route traffic to the LWS head pods in multinode deployments.
Why we need it
Added the
applabel (usingconstants.GetRawServiceLabel(componentMeta.Name)) to the Service selector to ensure precise pod selection.head
applabel in linkFixes #
How to test
Checklist
make testpasses locally