Skip to content

[Bugfix] Fix multinode Service selector to correctly match head pods#494

Open
bcfre wants to merge 1 commit intosgl-project:mainfrom
bcfre:fix-multinode-svc
Open

[Bugfix] Fix multinode Service selector to correctly match head pods#494
bcfre wants to merge 1 commit intosgl-project:mainfrom
bcfre:fix-multinode-svc

Conversation

@bcfre
Copy link
Contributor

@bcfre bcfre commented Jan 8, 2026

What this PR does

This PR fixes an issue where the multinode Service selector was incomplete, causing the Service to fail to correctly select and route traffic to the LWS head pods in multinode deployments.

Why we need it

Added the app label (using constants.GetRawServiceLabel(componentMeta.Name)) to the Service selector to ensure precise pod selection.

head app label in link

	headPodMeta.Labels["app"] = constants.GetRawServiceLabel(componentMeta.Name)
	headPodMeta.Labels["ray.io/node-type"] = "head"

Fixes #

How to test

Checklist

  • Tests added/updated (if applicable)
  • Docs updated (if applicable)
  • make test passes locally

Signed-off-by: bcfre <guo0xiong1feng@gmail.com>
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @bcfre, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a critical bug where the multinode Service selector was insufficient, preventing proper identification and routing of traffic to LWS head pods. By enhancing the selector with an additional app label, the system can now accurately target the intended pods, thereby restoring correct functionality for multinode deployments.

Highlights

  • Service Selector Fix: The multinode Service selector was incomplete, leading to incorrect pod selection and traffic routing issues for LWS head pods.
  • App Label Addition: The app label, derived from constants.GetRawServiceLabel(componentMeta.Name), has been added to the Service selector.
  • Improved Routing: This change ensures the Service correctly selects and routes traffic to LWS head pods in multinode deployments, resolving the bug.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@github-actions github-actions bot added inferenceservice InferenceService controller changes controller Controller changes multi-node Multi-node/distributed inference changes labels Jan 8, 2026
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request addresses a bug in multinode deployments where the Service selector was not specific enough, potentially causing it to select head pods from other deployments. The fix correctly adds the app label to the selector in NewMultiNodeReconciler, ensuring that the Service only targets the intended head pods for the specific InferenceService component. The change is straightforward, correct, and effectively resolves the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

controller Controller changes inferenceservice InferenceService controller changes multi-node Multi-node/distributed inference changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments