-
Notifications
You must be signed in to change notification settings - Fork 401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: temporary solution for DeepSeek V2 H100 layout conversion issue #1060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: ispobock <ISPObaoke@163.com>
zhyncs
changed the title
fix: tmp resolve deepseek v2 h100 layout issue
fix: temporary solution for DeepSeek V2 H100 layout conversion issue
Aug 12, 2024
zhyncs
changed the title
fix: temporary solution for DeepSeek V2 H100 layout conversion issue
fix: temporary solution for DeepSeek V2 Lite H100 layout conversion issue
Aug 12, 2024
DeepSeek V2 H100 TP8
|
ispobock
approved these changes
Aug 13, 2024
zhyncs
changed the title
fix: temporary solution for DeepSeek V2 Lite H100 layout conversion issue
fix: temporary solution for DeepSeek V2 H100 layout conversion issue
Aug 13, 2024
Potential issues, on the H100 other models if can be 128 128, here it was directly changed to 128 64, there might be performance degradation, need to verify and fix. |
|
env
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
fix #913
eval with Llama 3.1 8B Instruct gsm8k and it works well
tested with DeepSeek V2 Lite
Modification
Briefly describe the changes made in this PR.
Checklist
pre-commit run --all-files
or other linting tools are used to fix potential lint issues.