Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Docs CI When Compile Error #2323

Merged
merged 9 commits into from
Dec 4, 2024
Merged

Fix Docs CI When Compile Error #2323

merged 9 commits into from
Dec 4, 2024

Conversation

zhaochenyang20
Copy link
Collaborator

Motivation

I find that our current docs are broken in native_api:

https://sgl-project.github.io/backend/native_api.html

I changed the rules of docs CI. When one ipynb file fails to compile, the CI will end in error. And I changed native_api for a quick fix on update_weights_from_disk and encode (change reward to encode).

Also, I will fix #2322 this week. This is not highly prioritized and I have some personal things this week. I think I will edit the llama.py in our models for a quick fix on this.

Modifications

See this motivation above.

Checklist

  • Format your code according to the Contributor Guide.
  • Add unit tests as outlined in the Contributor Guide.
  • Update documentation as needed, including docstrings or example tutorials.

docs/backend/native_api.ipynb Outdated Show resolved Hide resolved
@merrymercy merrymercy merged commit 786be44 into main Dec 4, 2024
17 checks passed
@merrymercy merrymercy deleted the fix-docs-ci branch December 4, 2024 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Update weights from disk ends in runtime corruption for different size model
2 participants