Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

model: Intern vl 2.5 #3351

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

model: Intern vl 2.5 #3351

wants to merge 7 commits into from
+4,572 −243

Conversation

mickqian
Copy link
Contributor

@mickqian mickqian commented Feb 6, 2025

Motivation

Support InterVL2_5

Modifications

  1. InternVLChatModel

Checklist

  • Format your code according to the Code Formatting with Pre-Commit.
  • Add unit tests as outlined in the Running Unit Tests.
  • Update documentation / docstrings / example tutorials as needed, according to Writing Documentation.
  • Provide throughput / latency benchmark results and accuracy evaluation results as needed, according to Benchmark and Profiling and Accuracy Results.
  • For reviewers: If you haven't made any contributions to this PR and are only assisting with merging the main branch, please remove yourself as a co-author when merging the PR.

@mickqian
Copy link
Contributor Author

mickqian commented Feb 6, 2025

depends on #3203

@mickqian mickqian marked this pull request as ready for review February 9, 2025 08:24
@mickqian mickqian changed the title feature: Intern vl 2.5 model: Intern vl 2.5 Feb 20, 2025
Titan-p
Titan-p reviewed Feb 20, 2025
View reviewed changes
python/sglang/srt/managers/image_processor.py

all_frames = []

def load_image_internvl(image_file, input_size=448, max_num=12):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to introduce parameters for max/min numbers passed from the API, similar to what is done in lmdeploy?

internvl.md

    dict(type='image_url', image_url=dict(max_dynamic_patch=12, url='https://raw.githubusercontent.com/OpenGVLab/InternVL/main/internvl_chat/examples/image1.jpg')),

Titan-p
Titan-p reviewed Feb 20, 2025
View reviewed changes
python/sglang/srt/models/internvl.py
self.vision_model = InternVisionModel(
config=config.vision_config, quant_config=quant_config
)
self.language_model = InternLM2ForCausalLM(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add support to qwen/llama/.. language_model.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Titan-p Titan-p Titan-p left review comments

@merrymercy merrymercy Awaiting requested review from merrymercy merrymercy is a code owner

@Ying1123 Ying1123 Awaiting requested review from Ying1123 Ying1123 is a code owner

@zhyncs zhyncs Awaiting requested review from zhyncs zhyncs is a code owner

@hnyls2002 hnyls2002 Awaiting requested review from hnyls2002 hnyls2002 is a code owner

@ispobock ispobock Awaiting requested review from ispobock ispobock is a code owner

@ByronHsu ByronHsu Awaiting requested review from ByronHsu ByronHsu is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mickqian @Titan-p