Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Improve Docs CI Efficiency #3587

Merged
merged 9 commits into from
Feb 15, 2025

Conversation

shuaills
Copy link
Collaborator

Motivation

#3265

Modifications

Checklist

@shuaills shuaills changed the title [CI] Improve Docs CI efficiency [CI] Improve Docs CI Efficiency Feb 14, 2025
Copy link
Collaborator

@zhaochenyang20 zhaochenyang20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

@zhaochenyang20 zhaochenyang20 merged commit 7443197 into sgl-project:main Feb 15, 2025
13 of 19 checks passed
Comment on lines +37 to +38
"if is_in_ci():\n",
" from patch import launch_server_cmd\n",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 do we really want to include CI logic in the docs? I am afraid that it might confuse some users since not everyone knows what CI is.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we do not have better way 😂

chongli-uw pushed a commit to chongli-uw/sglang that referenced this pull request Feb 15, 2025
Co-authored-by: zhaochenyang20 <zhaochen20@outlook.com>
@shuaills shuaills deleted the CI/mem-fraction branch February 15, 2025 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants