Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Fix chat completion empty input #3793

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

Edenzzzz
Copy link
Contributor

@Edenzzzz Edenzzzz commented Feb 23, 2025

Motivation

Closes #3637 (comment). The server throws a confusing Input should be a valid list if request content is None. This fix instead throws a descriptive error. Subsequent changes are needed on the tool calling end to remove the logic of passing in None, which is illegal.

Modifications

Checklist

@Edenzzzz
Copy link
Contributor Author

cc @shuaills Please validate the change, thanks.

@shuaills
Copy link
Collaborator

Thanks, I'll have a look.

@shuaills shuaills self-assigned this Feb 23, 2025
Copy link
Collaborator

@shuaills shuaills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, thanks

Copy link
Collaborator

@shuaills shuaills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Edenzzzz Edenzzzz requested a review from shuaills February 25, 2025 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] pydantic validation errors for ChatCompletion
2 participants