Allow configuring plotly.js #106
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alyst
force-pushed
the
plotly_version_config
branch
from
bf6aa28
to
f38ab60
Compare
|
@sglyon Could you please take a look? |
|
Maybe, one should also adapt the deps to produce a more modern artifact? I just bumped the plotlyjs version in our StipplePlotly package in order to take advantage of the latest plotly features, e.g. alignment in sankey plots. So doing the same here is certainly a good idea. Before releasing, one could bump the version to today's latest version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently PlotlyBase.jl uses plotly.js 2.3.0 (also it's the version that plotly-base-artifacts provides), which is almost two years old and does not support some nice features, e.g. shape labels.
Technically, in the current PlotlyBase.jl the plotly.js version is specified in PLOTLYJS_VERSION constant.
This PR turns into into a configurable variable, that could be read/set with
PlotlyBase.plotly_version()andPlotlyBase.set_plotly_version()calls, respectively.The PR also updates the used plotly.js version to 2.33.0.