Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Kaleido_jll for Kaleido #42

Merged
merged 1 commit into from
Mar 26, 2021
Merged

Use Kaleido_jll for Kaleido #42

merged 1 commit into from
Mar 26, 2021

Conversation

giordano
Copy link
Contributor

@giordano giordano commented Mar 17, 2021

CC: @sglyon

@sglyon
Copy link
Owner

sglyon commented Mar 18, 2021

trying to get CI to work for mac....

I'll grab my machine and see if it works for me locally

@andreasnoack
Copy link

Bump. It would be great to get this one in since it's causing some issues for us when we want to relocate an application based on this package.

@MichaelHatherly
Copy link
Contributor

The kaleido call in _start_kaleido_process is failing for me on mac with the following:

julia> Kaleido_jll.kaleido() do bin
           run(`$bin plotly --disable-gpu`)
       end
[0326/093300.913531:FATAL:double_fork_and_exec.cc(126)] execvp /Users/mike/.julia/artifacts/704a8a26764bb0e8e719d78ef2f95eaab6ca2dbd/bin/Helpers/chrome_crashpad_handler: No such file or directory (2)
[0326/093300.914519:ERROR:file_io.cc(89)] ReadExactly: expected 8, observed 0
[0326/093300.916268:WARNING:resource_bundle.cc(435)] locale_file_path.empty() for locale en-US
{"code": 0, "message": "Success", "result": null, "version": ""}
[0326/093301.214846:WARNING:resource_bundle.cc(435)] locale_file_path.empty() for locale en-US
[0326/093301.217549:ERROR:network_service_instance_impl.cc(262)] Network service crashed, restarting service.
[0326/093301.217603:WARNING:resource_bundle.cc(435)] locale_file_path.empty() for locale en-US
[0326/093301.241694:WARNING:resource_bundle.cc(435)] locale_file_path.empty() for locale en-US
[0326/093301.295221:WARNING:resource_bundle.cc(435)] locale_file_path.empty() for locale en-US
[0326/093301.475566:ERROR:network_service_instance_impl.cc(262)] Network service crashed, restarting service.
[0326/093301.545798:WARNING:resource_bundle.cc(435)] locale_file_path.empty() for locale en-US
[0326/093301.548514:ERROR:network_service_instance_impl.cc(262)] Network service crashed, restarting service.
[0326/093301.626190:WARNING:resource_bundle.cc(435)] locale_file_path.empty() for locale en-US
[continues indefinitely...]

@giordano
Copy link
Contributor Author

The kaleido call in _start_kaleido_process is failing for me on mac with the following:

Does it work on master or latest stable version? Tests don't seem to have ever worked on macOS

@MichaelHatherly
Copy link
Contributor

0.5 is fine, master looks to be failing with a similar error.

@giordano
Copy link
Contributor Author

master looks to be failing with a similar error.

That's not a regression then 🙂

@sglyon
Copy link
Owner

sglyon commented Mar 26, 2021

I'm willing to merge, but would love some help fixing things up on OSX.

Unfortunately I'm stretched a bit thin right now and don't have time to dig in

@sglyon sglyon merged commit 35a6a29 into sglyon:master Mar 26, 2021
@MichaelHatherly
Copy link
Contributor

Might be worth seeing if https://github.com/plotly/Kaleido/releases/tag/v0.2.1 works any better.

@giordano giordano deleted the mg/kaleido-jll branch March 26, 2021 18:13
@giordano
Copy link
Contributor Author

@MichaelHatherly can you try to directly run kaleido in https://github.com/plotly/Kaleido/releases/download/v0.1.0/kaleido_mac.zip, and see if you can reproduce the same error? That's what we're using

@MichaelHatherly
Copy link
Contributor

Both that one and 0.2.1 give the same issues. Just testing out some different flags now to the binary, which might help...

@MichaelHatherly
Copy link
Contributor

See #44.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants