ensuring sssd.conf consistency during first Puppet run #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Interesting, I didn't think of authconfig modifying the config file. That makes sense though. Can you add a line to the spec test that makes sure this order happens in the RedHat blocks... |
|
All check finally passed! |
| @@ -11,6 +11,9 @@ | |||
| it { is_expected.to contain_package('authconfig').with_ensure('latest') } | |||
| it { is_expected.not_to contain_package('oddjob-mkhomedir') } | |||
| it { is_expected.not_to contain_service('oddjobd') } | |||
| it 'should pass' do | |||
| contain_exec('authconfig-mkhomedir').that_comes_before('File[sssd.conf]') | |||
There was a problem hiding this comment.
I think you need a is_expected.to here:
it 'should pass' do
is_expected.to contain_exec('authconfig-mkhomedir').that_comes_before('File[sssd.conf]')
end
|
If you want to bump the line length requirement just a bit, I wouldn't be opposed: I often bump it to 100 |
|
@curly8 can you add the same line to the RedHat 7 block also? |
Apparently - there is a limit on the length of the line that's why all this mess.
|
Done. Had to bump the Line Length to 105. Please review. |
|
Looks good |
edestecd
added a commit
that referenced
this pull request
Jan 13, 2016
ensuring sssd.conf consistency during first Puppet run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.