-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix service restart and messagebus issues #31
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I only had the one concern about the oddjobd require, but i'm 90% sure it is OK.
$extra_packages = [ | ||
'authconfig', | ||
] | ||
$extra_packages_ensure = 'latest' | ||
$manage_oddjobd = false | ||
} else { | ||
$service_dependencies = [] | ||
$extra_packages = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This clearly resolves #29
enable => true, | ||
hasstatus => true, | ||
hasrestart => true, | ||
require => Service[$sssd_service], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We lost this require in the move to the new dependencies class, but maybe we don't need it.
Does oddjobd need to start after sssd? I can't remember why...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm pretty sure oddjobd just needs to run, and whatever starts first of oddjobd or sssd is irrelevant. Authconfig changes on the other hand requires sssd to restart/reload.
This should fix issues #29 and #30