Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix service restart and messagebus issues #31

Merged
merged 9 commits into from
Jan 24, 2017
Merged

Fix service restart and messagebus issues #31

merged 9 commits into from
Jan 24, 2017

Conversation

sgnl05
Copy link
Owner

@sgnl05 sgnl05 commented Jan 21, 2017

This should fix issues #29 and #30

@sgnl05 sgnl05 added this to the 0.4.1 milestone Jan 21, 2017
@sgnl05 sgnl05 requested a review from edestecd January 21, 2017 13:42
@sgnl05 sgnl05 changed the title Fix for issue #29 and #30 Fix service restart and messagebus issues Jan 21, 2017
Copy link
Collaborator

@edestecd edestecd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I only had the one concern about the oddjobd require, but i'm 90% sure it is OK.

$extra_packages = [
'authconfig',
]
$extra_packages_ensure = 'latest'
$manage_oddjobd = false
} else {
$service_dependencies = []
$extra_packages = [
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This clearly resolves #29

enable => true,
hasstatus => true,
hasrestart => true,
require => Service[$sssd_service],
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We lost this require in the move to the new dependencies class, but maybe we don't need it.
Does oddjobd need to start after sssd? I can't remember why...

Copy link
Owner Author

@sgnl05 sgnl05 Jan 24, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm pretty sure oddjobd just needs to run, and whatever starts first of oddjobd or sssd is irrelevant. Authconfig changes on the other hand requires sssd to restart/reload.

@sgnl05 sgnl05 merged commit 770663f into master Jan 24, 2017
@sgnl05 sgnl05 deleted the restart_issue branch May 18, 2017 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants