Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting ensure => absent now further disables sssd #32

Merged
merged 4 commits into from
Mar 2, 2017

Conversation

machad
Copy link
Contributor

@machad machad commented Feb 22, 2017

  • For redhat-based systems, authconfig flags --disablesssd and --disablesssdauth
  • The sssd service sets ensure => stopped and enable => false

* For redhat-based systems, authconfig flags --disablesssd and --disablesssdauth
* The sssd service sets ensure => stopped and enable => false
@ghoneycutt
Copy link
Collaborator

Hi @machad

Try running puppet-lint -f manifests/* to automatically fix the style issues. That should make Travis happy.

@machad
Copy link
Contributor Author

machad commented Feb 22, 2017

@ghoneycutt Thanks. I've done that and committed the update. How do I trigger a re-check with travis?

@machad
Copy link
Contributor Author

machad commented Feb 23, 2017

It looks like the following test is failing:

https://travis-ci.org/sgnl05/sgnl05-sssd/jobs/204363675

Unfortunately, it's a bit unclear to me where the actual issue is short of maybe something specific to Ruby 1.9.3. If you can give me a hint, I'll be happy to dig in.

@edestecd
Copy link
Collaborator

We meed a new exclude in the .travis.yml file. Apparently the newest version of puppet 4.9.x does not support ruby 1.9.3...

@edestecd
Copy link
Collaborator

Adding this should do it:

- rvm: 1.9.3
  env: PUPPET_GEM_VERSION="~> 4" CHECK=test

@ghoneycutt
Copy link
Collaborator

opened PR #33 to fix this issue

@ghoneycutt
Copy link
Collaborator

@edestecd Puppet 4.9 also drops support for ruby 2.0.0, though this module does not support that version.

@machad
Copy link
Contributor Author

machad commented Feb 24, 2017

Thanks, @ghoneycutt. I'll keep an eye on that and once it's merged I'll pull it into this branch.

* Pulling in merge sgnl05#33 to fix Travis tests
@sgnl05 sgnl05 merged commit 917a778 into sgnl05:master Mar 2, 2017
@sgnl05
Copy link
Owner

sgnl05 commented Mar 2, 2017

Thanks! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants