Add compatibility with monolog 3.0 #1
Conversation
| * Map Monolog\Logger levels to Datadog's default status type | ||
| */ | ||
| private const DATADOG_LEVEL_MAP = [ | ||
| Logger::DEBUG => 'info', |
There was a problem hiding this comment.
Logger::DEBUG and the other constants are deprecated. Monolog now uses the Level enum. For PHP 8.0 compatibility, we are unable to use enum cases as array keys. This is only supported with PHP 8.2.
For that reason, I have removed the DATADOG_LEVEL_MAP and implemented the Monolog to Datadog level conversion directly in the method below as a match clause.
| public function format(array $record): string | ||
| protected bool $includeStacktraces = true; | ||
|
|
||
| public function format(LogRecord $record): string |
There was a problem hiding this comment.
Monolog changed the array to a class called LogRecord that implements ArrayAccess. So, it can be easily changed and still used as an array, at least for accessing the values.
| Level::Debug, Level::Info => 'info', | ||
| Level::Notice, Level::Warning => 'warning', | ||
| Level::Error, Level::Alert, Level::Critical, Level::Emergency => 'error', | ||
| }; |
There was a problem hiding this comment.
This is the new implementation of the level converter from Monolog levels to Datadog levels.
In the last version, we also only provided 3 Datadog levels. I think more differentiated levels are possible, but for now, I kept it as it was before. We can add more Datadog levels later.
|
Thank you for helping to move this on |
This PR adds compatibility with monolog 3.0.
I would recommend releasing this change as version 3.0.0. By that, all the "old" users that have
"^1.1"in their composer.json will not be affected. User who want to use the monolog 3 version can do so, by adding"^3.0"to their composer.json. We could also use version 2.0.0 for that, but with version 3.0.0 we would show the compatibility with monolog 3 and can orient the versioning on the major and minor version of monolog.Because the package does not have any tests yet, I was unable to test it by myself. I would test the 3.0 version as soon as it is released in one of our internal projects.