Full status compatibility with Datadog #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BernhardK91
commented
Apr 6, 2023
|
|
||
| if (isset($normalized['context']) && $normalized['context'] === []) { | ||
| $normalized['context'] = new stdClass; | ||
| } |
There was a problem hiding this comment.
LogRecord does not have a writable context property. The context is set on creating the LogRecord object. Converting the empty array to an empty stdClass object is not needed anymore.
BernhardK91
commented
Apr 6, 2023
|
|
||
| if (isset($normalized['extra']) && $normalized['extra'] === []) { | ||
| $normalized['extra'] = new stdClass; | ||
| } |
There was a problem hiding this comment.
Converting the empty array to an empty stdClass object is not needed anymore.
BernhardK91
commented
Apr 6, 2023
| Level::Debug, Level::Info => 'info', | ||
| Level::Notice, Level::Warning => 'warning', | ||
| Level::Error, Level::Alert, Level::Critical, Level::Emergency => 'error', | ||
| }; |
There was a problem hiding this comment.
There is no status attribute in the LogRecord object. Instead, we update the formatted string in DatadogHandler.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add full status (log level) compatibility in Datadog.
Also the required PHP version was bumped to 8.1 because monolog requires PHP 8.1 since version 3.0.0.
While refactoring the DatadogFormatter for compatibility with monolog, all custom changes became obsolet and the custom formatter was not needed anymore.
I have tested the changes in a Laravel application and it works fine: