Code

First fixes and tests for IntlBidi.#1

Code

Open

scholz-timo wants to merge 52 commits intosgolemon:bidisgolemon/php-src:bidifrom scholz-timo:bidiCopy head branch name to clipboard

+2,764-200

Commits

Commits on Sep 28, 2018

• Fixed return types for getReorderingMode() and getReorderingOptions().

  scholz-timo

  committed
  5ec8b65

  Copy full SHA for 5ec8b65

• Added embeddingLevels to IntlBidi::setPara()

  scholz-timo

  committed
  873fb9d

  Copy full SHA for 873fb9d

• Fixed IntlBidi::getReordered()

  scholz-timo

  committed
  6e423b8

  Copy full SHA for 6e423b8

• Added tests.

  scholz-timo

  committed
  e6c2f6b

  Copy full SHA for e6c2f6b

• Updated parameter parsing to the fast paramter parsing api.

  scholz-timo

  committed
  96f37e7

  Copy full SHA for 96f37e7

• Changed the call style of setLine to a java like approach and fixed the method.

  scholz-timo

  committed
  c85537b

  Copy full SHA for c85537b

• Added comment.

  scholz-timo

  committed
  3bce63d

  Copy full SHA for 3bce63d

• Removed duplicate in a test.

  scholz-timo

  committed
  340151c

  Copy full SHA for 340151c

Commits on Oct 2, 2018

• Removed unnecessary memory zeroing.

  scholz-timo

  committed
  55c07f0

  Copy full SHA for 55c07f0

• Made function arguments nullable.

  scholz-timo

  committed
  d785368

  Copy full SHA for d785368

• removed unnecessary emalloc calll, since erealloc with null has the same behavior.

  scholz-timo

  committed
  3cd9c17

  Copy full SHA for 3cd9c17

• Removed unnecessary comments and a unnecessary return

  scholz-timo

  committed
  f67506f

  Copy full SHA for f67506f

Commits on Nov 20, 2018

• Added tests.

  scholz-timo

  committed
  f26405c

  Copy full SHA for f26405c

• Renamed error method.

  Show description for 6dcd0e4
  scholz-timo

  committed
  6dcd0e4

  Copy full SHA for 6dcd0e4

• Removed comments.

  scholz-timo

  committed
  8874440

  Copy full SHA for 8874440

• Use FQN in constant

  JanSlabon

  committed
  9229362

  Copy full SHA for 9229362

• Added Copyright notice and source informations.

  scholz-timo

  committed
  e4f8844

  Copy full SHA for e4f8844

• Update ext/intl/tests/IntlBidi/IntlBidi_getBaseDirection_basic.phpt

  Show description for 2297451
  JanSlabon

  committed
  2297451

  Copy full SHA for 2297451

• Removed IntlBidi::getCustomizedClass() + code style.

  scholz-timo

  committed
  172566d

  Copy full SHA for 172566d

• Deleted obsolete test

  Show description for 2711a10
  JanSlabon

  committed
  2711a10

  Copy full SHA for 2711a10

Commits on Nov 21, 2018

• Added Copyright notices to tests.

  scholz-timo

  committed
  47bf076

  Copy full SHA for 47bf076

• Added and optimized various tests

  JanSlabon

  committed
  a84a7dc

  Copy full SHA for a84a7dc

• Fixed bug in IntlBidi::setLine()

  Show description for da78f5e
  scholz-timo

  committed
  da78f5e

  Copy full SHA for da78f5e

• Updated tests

  scholz-timo

  committed
  e45a197

  Copy full SHA for e45a197

• Updated test name

  scholz-timo

  committed
  c18d367

  Copy full SHA for c18d367

• Removed zend-callstack object generation from IntlBidi::setLine()

  scholz-timo

  committed
  208aeb4

  Copy full SHA for 208aeb4

• Tweaks in tests

  Show description for 757ceb5
  JanSlabon

  committed
  757ceb5

  Copy full SHA for 757ceb5

• Code style.

  scholz-timo

  committed
  94e7812

  Copy full SHA for 94e7812

• Merge branch 'bidi' of https://github.com/OmniFaR/php-src into HEAD

  scholz-timo

  committed
  944e5d0

  Copy full SHA for 944e5d0

• Code style

  JanSlabon

  committed
  7243c93

  Copy full SHA for 7243c93

• Added test for inverse behavior

  JanSlabon

  committed
  8cedca2

  Copy full SHA for 8cedca2

• Added test

  Show description for db9528b
  JanSlabon

  committed
  db9528b

  Copy full SHA for db9528b

• Added and optimized various tests

  JanSlabon

  committed
  7646902

  Copy full SHA for 7646902

• Added test for getVisualRun() method.

  JanSlabon

  committed
  54cbaa1

  Copy full SHA for 54cbaa1

• Added test for IntlBidi::getProcessedLength() method

  JanSlabon

  committed
  22c1f5d

  Copy full SHA for 22c1f5d

Commits on Nov 22, 2018

• Test optimizations

  JanSlabon

  committed
  6b2a29e

  Copy full SHA for 6b2a29e

Commits on Nov 30, 2018

• Implemented parent managemant.

  scholz-timo

  committed
  f984ec7

  Copy full SHA for f984ec7

• Optimized Code style.

  scholz-timo

  committed
  47e7e36

  Copy full SHA for 47e7e36

Commits on Dec 3, 2018

• Decoupled bidi instance from the zend_object.

  scholz-timo

  committed
  bd93331

  Copy full SHA for bd93331

• Added parent instance management.

  scholz-timo

  committed
  a1692a4

  Copy full SHA for a1692a4

• Added tests for maintaning bidi instances.

  scholz-timo

  committed
  df21864

  Copy full SHA for df21864

• Moved allocation logic in own function.

  Show description for ef9f04e
  scholz-timo

  committed
  ef9f04e

  Copy full SHA for ef9f04e

• Code style and value type.

  scholz-timo

  committed
  a0aa537

  Copy full SHA for a0aa537

• Code cleanup.

  scholz-timo

  committed
  b2383dd

  Copy full SHA for b2383dd

• Optimized test.

  scholz-timo

  committed
  a95a639

  Copy full SHA for a95a639

• Removed unnecessary space.

  scholz-timo

  committed
  de68d04

  Copy full SHA for de68d04

Commits on Dec 4, 2018

• code cleanup.

  scholz-timo

  committed
  500c2d5

  Copy full SHA for 500c2d5

• Changed call order for freeing bidi_objects.

  scholz-timo

  committed
  456776c

  Copy full SHA for 456776c

Commits on Dec 11, 2018

• Merge branch 'bidi' of https://github.com/OmniFaR/php-src into HEAD

  Show description for c61e4db
  scholz-timo

  committed
  c61e4db

  Copy full SHA for c61e4db

Commits on Dec 19, 2018

• Restructured specific setLine() test.

  JanSlabon

  committed
  01d5c8b

  Copy full SHA for 01d5c8b

Commits on Jan 29, 2019

• Fixed constructor and moved check into the constructor. Fixed nullable types.

  scholz-timo

  committed
  46e5c90

  Copy full SHA for 46e5c90

Commits on Jan 30, 2019

• Added support for chained setLine() calls.

  scholz-timo

  committed
  69e133c

  Copy full SHA for 69e133c