Feature/regenerate passes new session #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there, I added some tests to this branch. One is succeeding (the
regeneratechanges) but one is failing (thereloadchanges). I think the issue is that the session objects returned by regenerate vs reload are different.Either way, could you maybe add an example of how you plan to use these callbacks? I agree that they are convenient, but I also think they could introduce race conditions if someone responded to the request before these callbacks were issued.
Edit: At some point I undid + recommitted your last commit, and that somehow showed up in my history as a separate commit.