Skip to content

Commit

Permalink
Merge pull request openshift#778 from periklis/loki-enchachment-refresh
Browse files Browse the repository at this point in the history
[cluster-logging] Refresh loki enhancement proposal
  • Loading branch information
openshift-merge-robot authored May 27, 2021
2 parents 2fc2b6e + e09bd53 commit 8ba3cae
Showing 1 changed file with 6 additions and 12 deletions.
18 changes: 6 additions & 12 deletions enhancements/cluster-logging/loki-storage.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@ approvers:
- "@alanconway"
- "@jcantril"
creation-date: 2021-03-29
last-updated: 2021-03-29
status: provisional
last-updated: 2021-05-10
status: implemented
see-also: []
replaces: []
superseded-by: []
Expand All @@ -23,9 +23,9 @@ superseded-by: []

## Release Signoff Checklist

- [ ] Enhancement is `implementable`
- [ ] Design details are appropriately documented from clear requirements
- [ ] Test plan is defined
- [x] Enhancement is `implementable`
- [x] Design details are appropriately documented from clear requirements
- [x] Test plan is defined
- [ ] Operational readiness criteria is defined
- [ ] Graduation criteria for dev preview, tech preview, GA
- [ ] User-facing documentation is created in [openshift-docs](https://github.com/openshift/openshift-docs/)
Expand Down Expand Up @@ -362,7 +362,7 @@ The global/per-tenant ingestion limits are typical rate limiting control options

1. Log volume rate and burst size to omit unbound memory operations, i.e. by setting `IngestionRate` and `IngestionBurstSize`.
2. Label key and value lenghts to ensure faster log stream lookups, i.e. by setting `MaxLabelLength`, `MaxLabelValueLength`, `MaxLabelNamessPerSeries`.
3. Log stream limits to ensure better object storage utilization, i.e. by setting `MaxStreamsPerTenant`, `MaxGlobalStreamsPerTenant`.
3. Log stream limits to ensure better object storage utilization, i.e. by setting `MaxGlobalStreamsPerTenant`.

From the above the most significant for healthy Loki operations are the the log stream limits. Since Logs are aggregated per tenant and unique set of labels to log streams, a high number of streams has a negative impact on object storage usage.

Expand Down Expand Up @@ -402,12 +402,6 @@ type IngestionLimitSpec struct {
// +optional
MaxLabelNamessPerSeries int32 `json:"maxLabelNamesPerSeries,omitempty"`

// MaxStreamsPerTenant defines the maximum number of active streams
// per tenant, per ingester.
//
// +optional
MaxStreamsPerTenant int32 `json:"maxStreamsPerTenant,omitempty"`

// MaxGlobalStreamsPerTenant defines the maximum number of active streams
// per tenant, across the cluster.
//
Expand Down

0 comments on commit 8ba3cae

Please sign in to comment.