-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a pq-src crate for a bundled feature flag #46
Conversation
ef16d49
to
52f333c
Compare
I personally have only access to a linux development environment. That makes it hard to fix the remaining issues on windows/macos. If you are a user of diesel or pq-sys and use one of these platforms consider helping figuring out these issues. |
While I can't guarantee an allotted time per week to support this, I'm interested in contributing. I primarily develop on my local environment using a MacOS platform (ARM Chip). Would be happy to contribute if there are guidelines to doing this. I've skimmed over the diesel contributing guidelines, but have never contributed to diesel |
@fsasieta Thanks for your interest to contribute. There is no need to have guarantee any amount of time for this, as at least for me that's a free time project. For this specific change I'm interested in the following information:
I'm happy to help with as much information as I can if you hit a road block or if there are any other question. |
Attaching build logs on an intel mac, I hope it helps.
Looking at homebrew recipe, they pass a few more flags when building but not sure if they are relevant here |
Thanks for providing these logs ❤️ . I will see if they help an report back with results in the next days |
42b773b
to
bcbd9e9
Compare
ff69536
to
033b99c
Compare
@alcroito Thanks again for your help. I've merged this PR as it's now ready to be used 🥳 |
use clib provided by pq-src sgrif/pq-sys#46
use clib provided by pq-src sgrif/pq-sys#46
No description provided.