Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more responsive spinner #35

Merged
merged 3 commits into from
Jun 4, 2021
Merged

more responsive spinner #35

merged 3 commits into from
Jun 4, 2021

Conversation

sha1n
Copy link
Owner

@sha1n sha1n commented Jun 4, 2021

No description provided.

@sha1n sha1n added the enhancement New feature or request label Jun 4, 2021
@sha1n sha1n self-assigned this Jun 4, 2021
@sha1n sha1n force-pushed the spinner-enhancements branch from 1e574fe to b12c4be Compare June 4, 2021 16:08
@sha1n sha1n force-pushed the spinner-enhancements branch from b12c4be to 45d88b9 Compare June 4, 2021 16:09
@sha1n sha1n merged commit 7d491c7 into master Jun 4, 2021
@coveralls
Copy link

coveralls commented Jun 4, 2021

Pull Request Test Coverage Report for Build 906880617

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 36 of 37 (97.3%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.08%) to 91.707%

Changes Missing Coverage Covered Lines Changed/Added Lines %
spinner.go 36 37 97.3%
Totals Coverage Status
Change from base Build 897063574: 0.08%
Covered Lines: 564
Relevant Lines: 615

💛 - Coveralls

@sha1n sha1n deleted the spinner-enhancements branch June 12, 2021 08:43
sha1n added a commit that referenced this pull request Sep 24, 2021
* a more sane default spinner refresh rate

* better make defaults

* improved spinner responsiveness to title updates
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants