Merge pull request #336 from ArthurHoaro/login-hotfix

Allow uppercase letters in PHP sessionid format
shaarli · Sep 2, 2015 · 67ee143 · 67ee143
2 parents 53cc2b9 + 4d30975
commit 67ee143
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/application/Utils.php b/application/Utils.php
@@ -156,7 +156,7 @@ function is_session_id_valid($sessionId)
         return false;
     }
 
-    if (!preg_match('/^[a-z0-9]{2,32}$/', $sessionId)) {
+    if (!preg_match('/^[a-z0-9]{2,32}$/i', $sessionId)) {
         return false;
     }
 

diff --git a/tests/UtilsTest.php b/tests/UtilsTest.php
@@ -156,7 +156,7 @@ public function testCheckSupportedPHPVersion52()
      */
     public function testIsSessionIdValid()
     {
-        $this->assertTrue(is_session_id_valid('123456789012345678901234567890az'));
+        $this->assertTrue(is_session_id_valid('azertyuiop123456789AZERTYUIOP1aA'));
     }
 
     /**