Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import existing bookmarks should update tag list by merging the tags lists #2022

Open
t-w opened this issue Oct 3, 2023 · 0 comments
Open

Comments

@t-w
Copy link

t-w commented Oct 3, 2023

Currently there are 2 options for importing existing bookmarks (having the same URL):

  • not overwriting - basically any existing bookmark is skipped (time updated)
  • overwriting - all data related with the bookmark is overwritten

For me this clearly lacks the 3rd option: import an existing bookmark merging the lists of tags.

This can be implemented in several ways, adding dedicated option(s) etc. But it is better not to complicate (I am 100% for keeping Shaarli small and simple). The easiest way to add this is just to merge the list of tags by default (when not overwriting! - overwriting can be used for deleting / cleaning-up the tag list).

I made a simple change that does this, I will make a PR. The issue is created in case further discussion is needed.

@t-w t-w changed the title Import existing bookmarks should update tags list by adding new ones Import existing bookmarks should update tag list by adding new ones Oct 3, 2023
@t-w t-w changed the title Import existing bookmarks should update tag list by adding new ones Import existing bookmarks should update tag list by merging the tags lists Oct 3, 2023
@nodiscc nodiscc added the feature label Oct 3, 2023
t-w added a commit to t-w/Shaarli that referenced this issue Nov 11, 2023
@nodiscc nodiscc added this to the backlog to the future milestone Feb 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants