Highlight search results #205
Labels
Milestone
Comments
|
Great idea! |
|
+1 |
function highLightSearchTerms($string,$searchterm){
if (is_array($searchterm)){$searchterm=implode('', $searchterm); }
$repl='<em class="highlight_term">'.$searchterm.'</em>';
$replreg='\\1<em class="highlight_term">\\2</em>';
$rule='(?<!href="|src=")(.+)('.$searchterm.')';
return mb_eregi_replace($rule,$replreg,parse($string));
}https://github.com/broncowdd/Shinterest/blob/master/inc/functions.php |
|
I have something more or less working: ArthurHoaro/Shaarli:search-highlight I think this should be put on hold for now. #445 could help. |
ArthurHoaro
added a commit
to ArthurHoaro/Shaarli
that referenced
this issue
Oct 12, 2020
How it works:
1. when a fulltext search is made, Shaarli looks for the first
occurence position of every term matching the search. No change here,
but we store these positions in an array, in Bookmark's additionalContent.
2. when formatting bookmarks (through BookmarkFormatter
implementation):
1. first we insert specific tokens at every search result positions
2. we format the content (escape HTML, apply markdown, etc.)
3. as a last step, we replace our token with displayable span
elements
Cons: this tightens coupling between search filters and formatters
Pros: it was absolutely necessary not to perform the
search twice. this solution has close to no impact on performances.
Fixes shaarli#205
ArthurHoaro
added a commit
to ArthurHoaro/Shaarli
that referenced
this issue
Oct 16, 2020
How it works:
1. when a fulltext search is made, Shaarli looks for the first
occurence position of every term matching the search. No change here,
but we store these positions in an array, in Bookmark's additionalContent.
2. when formatting bookmarks (through BookmarkFormatter
implementation):
1. first we insert specific tokens at every search result positions
2. we format the content (escape HTML, apply markdown, etc.)
3. as a last step, we replace our token with displayable span
elements
Cons: this tightens coupling between search filters and formatters
Pros: it was absolutely necessary not to perform the
search twice. this solution has close to no impact on performances.
Fixes shaarli#205
ArthurHoaro
added a commit
to ArthurHoaro/Shaarli
that referenced
this issue
Oct 16, 2020
How it works:
1. when a fulltext search is made, Shaarli looks for the first
occurence position of every term matching the search. No change here,
but we store these positions in an array, in Bookmark's additionalContent.
2. when formatting bookmarks (through BookmarkFormatter
implementation):
1. first we insert specific tokens at every search result positions
2. we format the content (escape HTML, apply markdown, etc.)
3. as a last step, we replace our token with displayable span
elements
Cons: this tightens coupling between search filters and formatters
Pros: it was absolutely necessary not to perform the
search twice. this solution has close to no impact on performances.
Fixes shaarli#205
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When doing a full text search, return the results with matching text highlighted.
Implemented in the https://github.com/broncowdd/Shinterest fork
The text was updated successfully, but these errors were encountered: