Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installation from zip fails opening autoload.php #645

Closed
webtaster opened this issue Aug 29, 2016 · 10 comments
Closed

Installation from zip fails opening autoload.php #645

webtaster opened this issue Aug 29, 2016 · 10 comments
Assignees
Labels
documentation easy good place to start contributing enhancement question
Milestone

Comments

@webtaster
Copy link

webtaster commented Aug 29, 2016

First ever Github issue guys. Thanks for the software and sorry if this is mixed up/wrong.

Installing Shaarli 0.7.0 from the downloaded zip file fails. The shaarli web page is blank and this gets written in to the web server error log:

PHP Fatal error: require_once(): Failed opening required '/var/www/shaarli/vendor/autoload.php' (include_path='.:/usr/share/php:/usr/share/pear') in /var/www/shaarli/index.php on line 49

The autoload.php file does not exist. Neither does the "vendor" directory. I can work around the issue by creating the folder and an empty autoload.php file:

mkdir /var/www/shaarli/vendor
touch /var/www/shaarli/vendor/autoload.php

Version 0.6.5 did not have this error.

Environment: Debian 8, Apache 2.4, PHP 5.6.24. Composer not installed.

@ArthurHoaro
Copy link
Member

I think you installed the master branch tarball instead of 0.7.0 release. The master zip and git install now requires a composer install. See https://github.com/shaarli/Shaarli/wiki/Download-and-Installation

Although, we need to provide a proper error message for this.

@ArthurHoaro ArthurHoaro added enhancement easy good place to start contributing question labels Aug 29, 2016
@ArthurHoaro ArthurHoaro added this to the 0.8.0 milestone Aug 29, 2016
@webtaster
Copy link
Author

webtaster commented Aug 29, 2016

That Download-and-Installation page says Composer is required only when installing via "git clone". I was not installing by git clone, but just by downloading the zip file linked on the project front page. (Md5sum: ffa801473e788c405fa66c0e657a4c35 master.zip). Is downloading the master branch tarball not a valid method of installation for Shaarli ?

The Download-and-Installation page seems to say that this is a valid method if installation, in the section entitled "Download as an archive".

@ArthurHoaro
Copy link
Member

The doc mentions the stable and release zips, not the master one, which is the development branch. It could be clarified. The dev branch requires composer.

@virtualtam
Copy link
Member

I'd suggest releasing 0.8.0 as-is so we have a first batch of full-featured zip/tar archives and Docker images, and the docs can be wholly updated to state which Shaarli versions require Composer.

@virtualtam virtualtam self-assigned this Aug 29, 2016
@ArthurHoaro
Copy link
Member

Well, I believe an explicit error message may avoid noise here before releasing it.

@virtualtam
Copy link
Member

What should it contain/display?

A simple check would be looking for the presence of an autoload file, and pointing the user towards the installation page w/ Composer installation instructions.
Note that this doesn't cover other cases, e.g. the autoload is present but there are missing or outdated dependencies.

I'll look at how we can check for dependency versions from within Shaarli so we can display a nice beefy warning message instead of having the application fail. Something in the lines of: you need dependency D in revision R for feature F to work.

@ArthurHoaro
Copy link
Member

What should it contain/display?

A simple check would be looking for the presence of an autoload file, and pointing the user towards the installation page w/ Composer installation instructions.

Yes, something very simple, like:

**Error:** Dependency not found.  
If you installed Shaarli through git or using the development branch, please refer to the installation documentation [link] to  install Composer dependencies.

I'll look at how we can check for dependency versions from within Shaarli so we can display a nice beefy warning message instead of having the application fail. Something in the lines of: you need dependency D in revision R for feature F to work.

I'm not sure you can easily do that, but go ahead if you find anything.

@ghost
Copy link

ghost commented Aug 30, 2016

Thanks guys.

@webtaster
Copy link
Author

Now I understand. Sorry, bit of a Git noob. When I changed the branch to stable, the zip download link points to stable.zip, namely version 0.6.5. Yes, branch was "master" at the time of my first download (v 0.7.0).

@ArthurHoaro
Copy link
Member

While the master branch states its version is 0.7.0, it actually includes all changes in development made after the release. If you want the 0.7.0 release, refer to the release page.

virtualtam added a commit to virtualtam/Shaarli that referenced this issue Sep 4, 2016
Closes shaarli#645
Relates to shaarli#607

Signed-off-by: VirtualTam <virtualtam@flibidi.net>
virtualtam added a commit to virtualtam/Shaarli that referenced this issue Sep 4, 2016
Closes shaarli#645
Relates to shaarli#607

Signed-off-by: VirtualTam <virtualtam@flibidi.net>
ArthurHoaro pushed a commit that referenced this issue Nov 5, 2016
Closes #645
Relates to #607

Signed-off-by: VirtualTam <virtualtam@flibidi.net>
portailp pushed a commit to PortailPro/Shaarli that referenced this issue Mar 20, 2017
Closes shaarli#645
Relates to shaarli#607

Signed-off-by: VirtualTam <virtualtam@flibidi.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation easy good place to start contributing enhancement question
Projects
None yet
Development

No branches or pull requests

3 participants