-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some page titles are not retrieved properly #989
Comments
YouTube provides a REST API, but it requires having a Google account to create a Developer API token for authentication. Corresponding PHP library: php-youtube-api |
Honestly this sucks. Anyway... Shaarli gets the title correctly when either
The only case where title fetching fails is when using I'd like to avoid site-specific code, even more so if we have to import whole libraries for a single website. |
I wasn't talking about using their API, of course, because it requires an account, authentication token management, etc. Anyway, I agree with your suggestion @nodiscc. |
The titles aren't retrieved properly if they're not present using the
<title>
HTML tag (e.g. populated in JS, or any other exotic way).We can extend our ways to retrieve titles. A few examples:
document.title
og:title
Original issue:
With the new design (I suppose), the
<title>
tag only containsYouTube
, the actual title is populated using JS:Usually, I would avoid adding specific code for specific websites, however YouTube is a common website to shaare, so maybe we should add something to retrieve the actual title.
The text was updated successfully, but these errors were encountered: