Reverted to previous behaviour when deleting links. #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OK, I've had a bit of feedback concerning sebsauvage#90. While this simplifies the logic, when clearing out a bunch of tags or from a search, it's not really practical. What this does is that it checks if we're on a page that needs to redirect to self. so ?searchtags does, but ?Eox6ze (a permalink) does not. Also, thanks to some magic, HTTP_REFERER is always set and therefore we don't need to grab the current URL if redirecting to self. Tested on every page with a delete link
| } | ||
| } | ||
|
|
||
| header('Location: ' . $location); // After deleting the link, redirect to the home page. |
There was a problem hiding this comment.
The comment is wrong, should be "redirect to appropriate location"
|
Everything is fine except the minor comment problem. The commit message should also be "redirect to previous search when deleting a link" |
| isset($_GET['searchtags'])) { | ||
|
|
||
| if (isset($_POST['returnurl'])) | ||
| $location = $_POST['returnurl']; // Handle redirects given by the form |
There was a problem hiding this comment.
Please use curly brackets here as well, as you're doing with the HTTP_REFERER case just below.
|
Corrected in #114 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OK, I've had a bit of feedback concerning #90. While this simplifies the
logic, when clearing out a bunch of tags or from a search, it's not really
practical.
What this does is that it checks if we're on a page that needs to redirect
to self. so ?searchtags does, but ?Eox6ze (a permalink) does not.
Also, thanks to some magic, HTTP_REFERER is always set and therefore we
don't need to grab the current URL if redirecting to self.
Tested on every page with a delete link