PHP: ensure 5.3 compatibility

[virtualtam]

Relates to #250

Modifications

• add PHP 5.3 to Travis environments
• rewrite array declarations: explicitely use array() instead of []
• move checkPHPVersion to application/Utils.php
• move timezone functions to application/TimeZone.php
• improve test coverage
• bump required version from 5.1.0 to 5.3.x

[ArthurHoaro]

You forgot L949. But other than that everything seems to be working with PHP 5.3.3.

[virtualtam]

Actually, I think a couple methods can also be simplified and covered by tests:

• isTZvalid()
• templateTZform()

Some comments are outdated, too, there are references to 5.1.x compatibility

Working on it! :)

[virtualtam]

@ArthurHoaro I've done some additional edits and cleanup, could you confirm it works with a 5.3.x version?

[ArthurHoaro]

$citites_html is never used.

[virtualtam]

kenavo, $cities_html :)

[ArthurHoaro]

Aside from my minor comments, everything seems to be working with PHP 5.3.3 and unit tests are OK.

Great job!

[virtualtam]

Thanks for reviewing!
I'll see how the TZ methods can be improved (e.g. not only coding style) and write a bit more clever tests :)

[ArthurHoaro]

Perfect. Also, remind to update README.

[virtualtam]

Comments taken into account, here are the more significant changes since the last proposed PR:

• update README
• refactor TZ code for readability, more relevant docstrings and inline comments
• more in-depth unit tests: check generated HTML and Javascript content
• [EDIT] rebased :)

[ArthurHoaro]

That's a bit picky, but you can just return in_array.

[virtualtam]

thanks, I'll re-submit :)

[ArthurHoaro]

Great job! I'll make a final test in 5.3 and we can merge this. :)

[virtualtam]

Thanks for testing :)