-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version check: check against latest version on github #31
Conversation
* release process: please update this file when releasing a new version on github
…rli/Shaarli * fixes #5
The last released version is 0.0.42 beta, whereas the version indicated in the shaarli_version.txt file is still 41. Look at this example, the link If we used the Latest Release functionality (not sure why it's now working for us yet, maybe we need to make a formal release object?) we could use the value it's redirected to to determine the latest version number, and that way not need to update the text file. But I guess that could be done as an improvement later on, so I'm OK with this merge for now. |
I think it is fine. I agree with @e2jk that it would be nice to avoid redundant information, but I do not think the current method based on |
Checking against a simple text file is also a lot easier (one-liner), and more portable (if people want to maintain their own deployments, no need to setup RSS feeds, redirections, no dependency against github, also easier to maintain the watchfile for debian packaging) |
Version check: check against latest version on github
I agree with the fact that the file is easier, except for the last +Emilien |
This is not what I see in the watchfile in ftp://ftp.fr.debian.org/debian/pool/main/s/shaarli/shaarli_0.0.41~beta~dfsg2-5.debian.tar.xz debian/watch:
|
Indeed, and that's the reason why the watchfile is currently not working ;) I have made the change to point to the Shaarli organization in this commit, For some reason I realise I haven't uploaded the newest version (0.0.42 |
Fixes #5
It replaces the check to http://sebsauvage.net/files/shaarli_version.txt with https://raw.githubusercontent.com/shaarli/Shaarli/master/shaarli_version.txt (file in the shaarli/Shaarli repository, has to be updated on every new release)