Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Pubsubhub to a default plugin #620

Merged
merged 2 commits into from
Dec 20, 2016
Merged

Conversation

ArthurHoaro
Copy link
Member

@ArthurHoaro ArthurHoaro commented Aug 2, 2016

  • Adds placeholders in feeds templates to specify which hub is used (render_feed hook).
  • Retrieve the publisher lib with Composer.
  • Notify the hub everytime a link is saved (save_link).
  • Adds a default PHP fallback if cURL is not installed.
  • Silently log exceptions.

TODO:

  • Update plugin doc for the new placeholders

Fixes #459

@ArthurHoaro ArthurHoaro added plugin bells and whistles documentation template HTML rendering in review 3rd party interoperability with third-party platforms labels Aug 2, 2016
@ArthurHoaro ArthurHoaro added this to the 0.8.0 milestone Aug 2, 2016
@ArthurHoaro ArthurHoaro self-assigned this Aug 2, 2016
@ArthurHoaro
Copy link
Member Author

The dependency isn't compatible with PHP 5.3 (or at least their composer.json say so). Pushing to v0.9.0.

@ArthurHoaro ArthurHoaro modified the milestones: 0.9.0, 0.8.0 Aug 2, 2016
@virtualtam
Copy link
Member

Additionally, the Pubsubhubbub publisher should be deployed through Composer - #613

@ArthurHoaro
Copy link
Member Author

Yeah, that's what I did.

@ArthurHoaro ArthurHoaro force-pushed the pubsubhub branch 2 times, most recently from e5f47cf to 1d91be1 Compare December 20, 2016 10:36
@Lucas-C
Copy link

Lucas-C commented May 9, 2017

FYI, there is dead code remaining here:
https://github.com/shaarli/Shaarli/blob/master/index.php#L234

@ArthurHoaro
Copy link
Member Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3rd party interoperability with third-party platforms documentation plugin bells and whistles template HTML rendering
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants