Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup: explicitely loop over PHP variables in templates #660

Merged
merged 1 commit into from
Oct 17, 2016
Merged

Cleanup: explicitely loop over PHP variables in templates #660

merged 1 commit into from
Oct 17, 2016

Conversation

virtualtam
Copy link
Member

@virtualtam virtualtam commented Oct 16, 2016 •
edited
Loading

Relates to #613

Before: {loop="someVariable"}
After: {loop="$someVariable"}

@virtualtam
Cleanup: explicitely loop over PHP variables in templates
dec5fe9 
Relates to shaarli#613

Before: {loop="someVariable"}
After:  {loop="$someVariable"}

Signed-off-by: VirtualTam <virtualtam@flibidi.net>
@virtualtam virtualtam added cleanup code cleanup and refactoring please test easy good place to start contributing template HTML rendering in review labels Oct 16, 2016
@virtualtam virtualtam added this to the 0.8.1 milestone Oct 16, 2016
@virtualtam virtualtam self-assigned this Oct 16, 2016
@virtualtam virtualtam mentioned this pull request Oct 16, 2016
Closed
3 tasks
ArthurHoaro
ArthurHoaro approved these changes Oct 17, 2016
View reviewed changes
Copy link
Member

@ArthurHoaro ArthurHoaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested

@virtualtam virtualtam merged commit 209aa96 into shaarli:master Oct 17, 2016
@virtualtam virtualtam deleted the fix/template/loop branch October 17, 2016 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArthurHoaro ArthurHoaro ArthurHoaro approved these changes

Assignees

@virtualtam virtualtam

Labels
cleanup code cleanup and refactoring easy good place to start contributing template HTML rendering
Projects
None yet
Milestone
0.8.1
Development

Successfully merging this pull request may close these issues.
2 participants
@virtualtam @ArthurHoaro