Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LinkDB: code cleanup #673

Merged
merged 3 commits into from
Oct 21, 2016
Merged

LinkDB: code cleanup #673

merged 3 commits into from
Oct 21, 2016

Conversation

virtualtam
Copy link
Member

A bit of cleanup of LinkDB's internals before working on #351:

  • apply coding conventions (no leading underscore in privates' names)
  • simplify method names
  • explicit (public) method visibility

@virtualtam
LinkDB: do not prefix privates with an underscore
628b97c 
Relates to shaarli#95

Signed-off-by: VirtualTam <virtualtam@flibidi.net>
@virtualtam
LinkDB: update datastore method names
f21abf3 
Relates to shaarli#95

Signed-off-by: VirtualTam <virtualtam@flibidi.net>
@virtualtam
LinkDB: explicit method visibility
735ed4a 
Relates to shaarli#95

Signed-off-by: VirtualTam <virtualtam@flibidi.net>
@virtualtam virtualtam added cleanup code cleanup and refactoring easy good place to start contributing in review labels Oct 20, 2016
@virtualtam virtualtam added this to the 0.8.1 milestone Oct 20, 2016
@virtualtam virtualtam self-assigned this Oct 20, 2016
@virtualtam virtualtam merged commit 3d5e0ae into shaarli:master Oct 21, 2016
@virtualtam virtualtam deleted the cleanup/linkdb branch December 22, 2016 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArthurHoaro ArthurHoaro ArthurHoaro approved these changes

Assignees

@virtualtam virtualtam

Labels
cleanup code cleanup and refactoring easy good place to start contributing
Projects
None yet
Milestone
0.8.1
Development

Successfully merging this pull request may close these issues.
2 participants
@virtualtam @ArthurHoaro