Remove $feedurl from RSS links

[ahmet2mir]

Other links haven't $feedurl var. Behind a reverse proxy with a path, rss point to server/?do=rss instead of server/path/?do=rss

[nodiscc]

Hi @ahmet2mir thanks for the pull request. I'd like to make sure we are not duplicating efforts, there is a proposed solution for reverse proxies (this bug is tracked in #17), and it has been implemented in a temporary, experimental branch skip-port-detection in https://github.com/nodiscc/Shaarli (this commit nodiscc@5c3605f).

I don't have a reverse proxy at hand to test this or your solution. I've asked for testers in sebsauvage#101, but got no replies.

So, bugs currently affecting reverse proxies are:

• Skip webserver port detection if running behind a reverse proxy sebsauvage/Shaarli#209 ajax-based functions stop working
• Self in Atom (via reverse proxy) sebsauvage/Shaarli#180 self-link in ShowATOM function does not work
• Overriding detected server port sebsauvage/Shaarli#60 URLs contain the server port (probably a duplicate of:)
• Do not repeat the port after HTTP_HOST sebsauvage/Shaarli#165 broken URLs
• No login possible while using port forwarding (no standard-port) sebsauvage/Shaarli#183 no login possible when using port forwarding
• RSS feed has an incorrect url sebsauvage/Shaarli#101 RSS feed has an incorrect URL
• Shaarli behind an apache proxy sebsauvage/Shaarli#132 Shaarli behind an apache proxy

So far, I think your Pull Request ony addresses the last point, right?

As you have a reverse proxy, can you test the mentioned patch? (We'd rather fix all reverse proxy issues with a single solution, it would be better than hacking every separate bug)

Thanks again

[nodiscc]

Does anyone else have a Shaarli on a non-standard port behind an apache proxy? What bugs are you able to reproduce? Does the skip-port-detection patch or the one proposed here fix any of your issues?

[ahmet2mir]

If you have docker, you can test this https://github.com/ahmet2mir/dockerfiles/tree/master/reverseproxy in the full example I run a shaarli.
It's not a port detection issue (both on 80), it's due do "indexUrl()" who use $_SERVER["SCRIPT_NAME"].
The docker shaarli is on http://private/ and my reverse http://public/shaarli/. So indexurl take the correct host but wrong path.
There is nothing on $SERVER side to obtains the correct path :/

[nodiscc]

Ok there were some updates in sebsauvage#101. As you said the 2 bugs are unrelated. I'll test your patch to see if it doesn't unexpectedly break things, please allow some time for the review. Feedback from other users/maintainers is also welcome.

Thanks again

[ahmet2mir]

I think that we need to remove totally indexUrl.

[nodiscc]

@ahmet2mir I've just merged #98; Shaarli now uses php's SERVER_NAME instead of HTTP_HOST. Does this fix the rss bug on your reverse proxy setup? Please let me know.

We can investigate removing indexUrl later

[nodiscc]

Closing this. @ahmet2mir please test against the latest master and feel free to reopen a PR/bug if this doesn't fix your problem.