Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misc refactoring and performance improvements. #65

Merged
merged 3 commits into from
Jan 25, 2021
Merged

Misc refactoring and performance improvements. #65

merged 3 commits into from
Jan 25, 2021

Conversation

TangoMan75
Copy link
Collaborator

@TangoMan75 TangoMan75 commented Jan 22, 2021 •
edited
Loading

Scale down items variable scope to method level.

  • Makes component stateless and usable as a service.

Refactor parseString method.

  • Replaced ugly $i increment variable with array.

Remove unnecessary ksort in parseString method.

  • Result $items array indexes are numeric, ksort returns the exact same array everytime.

ArthurHoaro
ArthurHoaro approved these changes Jan 25, 2021
View reviewed changes
Copy link
Member

@ArthurHoaro ArthurHoaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvements, thank you!

@ArthurHoaro ArthurHoaro merged commit 76ff8d7 into shaarli:master Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArthurHoaro ArthurHoaro ArthurHoaro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TangoMan75 @ArthurHoaro