fix: guarantee GitHub organisation secrets are replaced correctly

Previously, replacements were deleting the secret after the replacement had completed, meaning the secret itself is no longer present See pulumi/pulumi-github#250
shabados · Oct 22, 2023 · 5192a7d · 5192a7d
1 parent 4e61cdd
commit 5192a7d
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/environment/github-secrets.ts b/environment/github-secrets.ts
@@ -12,7 +12,7 @@ const githubSecretsModule = async ( { cluster: { kubeconfig } }: Options ) => {
     secretName: `${environment.name.toUpperCase()}__KUBECONFIG`,
     visibility: 'all',
     plaintextValue: kubeconfig,
-  } )
+  }, { deleteBeforeReplace: true } )
 }
 
 export default githubSecretsModule
diff --git a/tools/azure-secrets.ts b/tools/azure-secrets.ts
@@ -32,6 +32,6 @@ const azureSecretsModule = async ( {
   secretName: `${environment.name.toUpperCase()}__AZURE_${secretName}`,
   visibility: 'all',
   plaintextValue: value as Output<string>,
-} ) )
+}, { deleteBeforeReplace: true } ) )
 
 export default azureSecretsModule