Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Support RTL for Dialog #1635

Closed
wants to merge 1 commit into from
Closed

Conversation

aashahin
Copy link

No description provided.

@vercel
Copy link

vercel bot commented Sep 30, 2023

@aashahin is attempting to deploy a commit to the shadcn-pro Team on Vercel.

A member of the Team first needs to authorize it.

@aashahin aashahin changed the title Added Support RTL Added Support RTL for Dialog Sep 30, 2023
@shadcn
Copy link
Collaborator

shadcn commented Oct 3, 2023

@aashahin What are your thoughts on this PR #1638?

@aashahin
Copy link
Author

aashahin commented Oct 3, 2023

@shadcn It does not fully support the direction, as it forces the layout to shift from right to left, leaving problems with spacing, and some components must be added support to directly, as I did. I replaced left with start, and accordingly, it will start from the beginning of the page’s direction, whether from the right or the left.

@shadcn
Copy link
Collaborator

shadcn commented Oct 19, 2023

@aashahin I'm going to close this in favor of #1638. We're looking into adding RTL support via the cli. We could use some help with testing and feedback.

@shadcn shadcn closed this Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants