fix(shadcn): fix transformRsc to account for ' #5518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bcorbold is attempting to deploy a commit to the shadcn-pro Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
niktekusho
pushed a commit
to niktekusho/shadcnui
that referenced
this pull request
Nov 21, 2024
* fix(shadcn): fix transformRsc to account for ' * chore: add changeset --------- Co-authored-by: shadcn <m@shadcn.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For external registry files that use single quote formatting, the
'use client'directive will not be removed for projects withrsc: falseconfigured due to thetransformRscutilThis PR updates the equality check to a regex to fix this use case
Sandbox env
https://codesandbox.io/p/devbox/dark-hill-lht8mm
pnpx shadcn@latest add http://localhost:3000/registry/custom-button.jsoncustom-button.tsxwill still have the directive even thoughrscis set tofalsein thecomponents.json