feat(components): Add Tailwind v4 theme code generation #6668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This feature introduces a options on the theme generation page, allowing users to select their target Tailwind CSS version (<v4 or v4+). This ensures that the generated CSS is compatible with the user's project. Previously, the theme generator only produced CSS compatible with older Tailwind versions, which caused issues for users on v4. This change addresses those compatibility problems. The implementation involves modifying the CSS generation logic to handle the differences between Tailwind versions. Specifically, v4 requires the use of `@theme inline` and `hsl()` wrappers for color values. The selected version is used to determine the correct CSS syntax. This change improves the user experience by providing a more flexible and robust theme generation process.
|
@Jehoshaphat-Obol is attempting to deploy a commit to the shadcn-pro Team on Vercel. A member of the Team first needs to authorize it. |
Jehoshaphat-Obol
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature introduces a options on the theme page, allowing users to select their target Tailwind CSS version (<v4 or v4+). This ensures that the generated CSS is compatible with the user's project.
Previously, the theme generator only produced CSS compatible with older Tailwind versions, which caused issues for users on v4. This change addresses those compatibility problems.
The implementation involves modifying the CSS generation logic to handle the differences between Tailwind versions. Specifically, v4 requires the use of
@theme inlineandhsl()wrappers for color values. The selected version is used to determine the correct CSS syntax.This change improves the user experience by providing a more flexible and robust theme generation process.