fix(docs): improve TanStack Form example performance #9255
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
onChangetoonBlurin the ExampleForm componentProblem
The ExampleForm in the internal sink uses
validators: { onChange: exampleFormSchema }, which validates the entire Zod schema on every keystroke. The schema contains expensive operations (regex checks, date calculations, refine() calls), causing noticeable input lag when typing in text fields.Note: The GitHub issue mentions the "Bug Report Form", but that form (
form-tanstack-demo.tsx) already usesonSubmitvalidation, which is correct. The actual performance issue is inexample-form.tsx.Solution
Changed validation to
onBlurstrategy:form-tanstack-array.tsx)File Changed
apps/v4/app/(internal)/sink/(pages)/tanstack-form/example-form.tsx(line 80)Test plan
Fixes #9222